Fixed a bug in kiwix-desktop's source publishing step #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug was there since 2018. It's strange that it didn't cause problems with previous releases. The most plausible explanation is that this is the first time when the sources of kiwix-desktop are being published via this procedure.
veloman-yunkan
force-pushed
the
fix_for_publishing_kiwix-desktop_sources
branch
from
af3277f to
a5a6ba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was there since 2018. It's strange that it didn't cause problems with previous releases. The most plausible explanation is that this is the first time when the sources of kiwix-desktop are being published via this procedure.
Should fix the issue with the failure of the Linux (native_dyn, jammy) job of the
kiwix-desktop2.4.0 release workflow run.